Fix isUpdating for DS.AdapterPopulatedRecordArray#update() - #4316
Merged
bmac merged 2 commits intoApr 9, 2016
Merged
Conversation
| }); | ||
|
|
||
| test("a query can be updated via `update()`", function(assert) { | ||
| let done = assert.async(); |
Contributor
There was a problem hiding this comment.
Is this done needed? I thought the run loop would remove the need for this?
Contributor
Author
There was a problem hiding this comment.
You are absolutely right 👍 Removed the done and the amount of expected assertions, since this is handled by the run-loop...
Contributor
|
Overall looks good. |
The `isUpdating` flag is not set to `true` when the `update()` method on a `DS.AdapterPopulatedRecordArray` is invoked. As with the flag on `DS.RecordArray`, this should be `true` until the update is finished and the array contains the most reset result for the query, fetched from the adapter.
This was referenced May 16, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isUpdatingflag is not set totruewhen theupdate()method ona
DS.AdapterPopulatedRecordArrayis invoked. As with the flag onDS.RecordArray, this should betrueuntil the update is finished andthe array contains the most reset result for the query, fetched from the
adapter.
The
[FEATURE]commit DRY's up some code in theDS.AdapterPopulatedRecordArrayand by this makes it easier to cherry-pick this bugfix intobeta(where this feature is not yet available).