maxUrlLength -> maxURLLength

[sly7-7]

Fixes #3101
@igorT Let me know if I can remove the deprecation warning (it seems to me that people may override groupsForHasMany and use this property, like in the test)

@pangratz When this is merged, you will have to rebase your PR #3099 😅

[pangratz]

@sly7-7 Thanks for the heads up!

[igorT]

Shouldn't turn it into a computed if even we weren't calling get on it. You can deprecate using deprecateProperty/making a prop getter similar to https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/snapshot.js#L39

[sly7-7]

@igorT Done, AppVeyor is angry with npm though...

[igorT]

Might have needed something more for IE8, but I think we are gonna drop it today

[sly7-7]

Sorry, I missed that. What could we do for IE8 ? I can at least put this defineProperty inside a Ember.platform.hasPropertyAccessors block, but how could I do it for IE8 ? (Am I missing something or Ember.deprecateProperty is just a noop on IE8 ?)

[igorT]

We are dropping IE8 so no worries

[igorT]

Also wouldn't this break if someone subclassed the adapter to provide their own limit as they would override this getter? cc @rwjblue whats the proper way of doing this

[bmac]

Here is the code Ember uses to deprecate a property. https://github.com/emberjs/ember.js/blob/1b5adaa65d20af4f4e57702ea34aa0dcc42e1489/packages/ember-metal/lib/deprecate_property.js#L24-L43. It seems to work even if a user overrides this getter. Its also usually called on the classes's prototype object.

[sly7-7]

@bmac I saw this too, so that basically mean that people developping in a world without property accessors, they just don't have the deprecation warning, right ?

[bmac]

Correct

[sly7-7]

Ok, so @igorT Do you want me to wrap that the same way Ember does ?

[bmac]

@sly7-7 yes lets do it the way Ember does it.

[sly7-7]

@bmac Ok, Will do this in couple hours. Is this the last thing before merge, or is there any other concerns ?

[sly7-7]

@bmac Should be good

[bmac]

This should be defined on RestAdapter.prototype.

[bmac]

Tested it locally and everything looks good. 👍