feat(VSkeletonLoader): add types prop to v-skeleton-loader - #18878
Closed
MichaelGoff wants to merge 1 commit into
Closed
feat(VSkeletonLoader): add types prop to v-skeleton-loader#18878MichaelGoff wants to merge 1 commit into
MichaelGoff wants to merge 1 commit into
Conversation
I merge the custom `types` prop into the `rootTypes` and set that as a computed to keep it reactive. I opted to move the gen* functions into setup to inherit the `mergedTypes` computed rather than pass it around as an extra parameter. Happy to set it up as a parameter instead if desired.
KaelWD
force-pushed
the
dev
branch
2 times, most recently
from
September 10, 2025 13:29
6331ca7 to
564ccc8
Compare
J-Sek
force-pushed
the
dev
branch
3 times, most recently
from
October 8, 2025 15:22
a7fa817 to
2e2cddb
Compare
J-Sek
force-pushed
the
dev
branch
2 times, most recently
from
March 29, 2026 00:37
5b257fd to
86800d9
Compare
Contributor
|
closing in favor of #23037 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vuetify 2 included the prop
typeswhich allowed you to define and use your own custom skeleton types with the existing types that Vuetify provides. This prop was not present in Vuetify 3.In the component, I merge the custom
typesprop into therootTypesand set that as a computed to keep it reactive.I opted to move the gen* functions into
setupto inherit themergedTypescomputed rather than pass it around as an extra parameter. Happy to set it up as a parameter instead if desired.I'm not sure if there's anything I need to do on the documentation. I saw that there was already a description for the types prop in
api-generator/src/locale/en/VSkeletonLoader.jsonMarkup: