feat: setup devtools integration - #1949
Conversation
|
Haven't tested nested modules yet |
|
Actions logging |
after closing/re-opening the devtools
|
Store filtering |
|
@kiaking I've moved the functions from |
kiaking
left a comment
kiaking
left a comment
There was a problem hiding this comment.
AWESOME WORK GUYS!!!! 🎉 🎉 🎉 🎉 🎉
@Akryum I left 1 comment, I wasn't 100% sure (unused color vars).
Also, what do you think about positioning actions on top of mutations in Timeline view. It's really a personal preference but for me it kinda feels more natural to have actions timeline on top.
Especially when actions are async, having timeline range bar on top of mutations dots might look better...? Again, just my personal preference though 😳
| /** | ||
| * Extracted from tailwind palette | ||
| */ | ||
| const COLOR_PINK_500 = 0xec4899 |
There was a problem hiding this comment.
Should we remove other than
const COLOR_LIME_500 = 0x22d3eeconst COLOR_DARK = 0x666666const COLOR_WHITE = 0xffffff
Since seems like we're not using them...?
There was a problem hiding this comment.
Oh OK cool! I'll remove it then 👍 I wasn't sure if Devtools was doing some ultra magic to pick these colors up some how haha
|
Pushed small code style change and fix linter error. Lint error is still there due to #1949 (comment). Not sure why CI is not picking it up 🤔 |
| "vue": "^3.0.2" | ||
| }, | ||
| "dependencies": { | ||
| "@vue/devtools-api": "^6.0.0-beta.7" |
There was a problem hiding this comment.
If it is added as a dependency, shouldn't we mark it as external too? I will need to follow the same on Vue Router. Currently it is not marked as external and therefor is only a dev dependency
There was a problem hiding this comment.
I thought this was here to support Type imports in TS...? In that case I think it should be the same in Router too. Am I correct @Akryum ?
There was a problem hiding this comment.
It does nothing except calling a function or putting the plugin into a queue array.
I don't know, I also thought about it but then the actions layer can grow its height where the mutations will not. So it will probably be pushed far at the bottom if there are a lot of parallel actions going on. |
|
@Akryum Ah good point. Nice catch. In that case yeah it make sense to have actions under mutations 👍 |
kiaking
added
4.x
build
3 participants
Closes #1942