fix: navigation key names - #2046
Merged
Merged
Conversation
❌ Deploy Preview for vue-test-utils-v1 failed.
|
lmiller1990
reviewed
Jan 17, 2023
lmiller1990
left a comment
Member
There was a problem hiding this comment.
Any chance you can add a test for this? Thanks!
Contributor
Author
Sorry, but there is test already. I just updated expected values according to the common spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
When using keyboard events (
keyup,keydown), thekeyevent param is passed incorrectly for navigation keys. it should beArrowRightinstead of justRightaccording to the same document that is referred in the code: https://github.com/ashubham/w3c-keys/blob/48d9dc98a6468447bc15db8d4b15ce19ce157869/index.ts#L17Left,Right,UpandDownwere used in Internet Explorer, Edge (16 and earlier), and Firefox (36 and earlier) according to MDN. Those browsers are so old that they are deprecated.