fix #2024 - Accessing HTMLElement and SVGElement through window - #2025
Merged
Conversation
❌ Deploy Preview for vue-test-utils-v1 failed.
|
lmiller1990
reviewed
Nov 7, 2022
Member
|
Cool, thanks. I will do a release in a few days, I want to try and get a couple more things in, thanks for your patience 👍 |
Member
|
Sorry this took a long time, life got busy. I did a release with this patch: https://github.com/vuejs/vue-test-utils/releases/tag/v1.3.4 |
Contributor
Author
No problem. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: #2024
The method
isStyleVisiblewas ported from jest-dom as it is declared on the function comment but looking at js-dom code, they don't haveinstanceof SVGElementbut, instead,instanceof window.SVGElementwhich makes sense and fixes issue #2024.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)