Skip to content

docs: modify the wrong Chinese word - #1922

Merged
lmiller1990 merged 2 commits into
vuejs:devfrom
whyer11:patch-2
Jul 22, 2022
Merged

docs: modify the wrong Chinese word#1922
lmiller1990 merged 2 commits into
vuejs:devfrom
whyer11:patch-2

Conversation

@whyer11

@whyer11 whyer11 commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

"阀值" is a wrong word in Chinese, "阈值" should be used here

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: documents

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

"阀值" is a wrong word in Chinese, "阈值" should be used here
@whyer11

whyer11 commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

why checks all run failed?

image

@lmiller1990

Copy link
Copy Markdown
Member

I guess we need to update the Netlify infrastructure. I have no idea how to do this, I will find out. Maybe @afontcu has some context 🤔 ?

@whyer11

whyer11 commented Nov 16, 2021

Copy link
Copy Markdown
Contributor Author

any update?

@lmiller1990

Copy link
Copy Markdown
Member

I do not have access to the Netlify account to update the image, but I asked someone who does. Should be able to get this fixed this week.

@lmiller1990

Copy link
Copy Markdown
Member

Still no luck. I miss GH pages, it was a lot easier that having to manage access to multiple tools. Maybe we should move back to that.

@lmiller1990

Copy link
Copy Markdown
Member

Gonna merge this while I try to chase up a Netlify fix.

@lmiller1990
lmiller1990 merged commit a9dace1 into vuejs:dev Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants