fix: restore chaining and CSS selectors for findComponent - #1910
Conversation
|
@lmiller1990 could you please cut a release if/when this one is merged :) Thank you |
|
@lmiller1990 sorry, just a friendly ping. This is a significant change greatly simplifying our migration to Vue3 |
lmiller1990
left a comment
lmiller1990
left a comment
There was a problem hiding this comment.
One comment, more of a question!
| __findAll( | ||
| rawSelector: Selector, | ||
| selector: Object, | ||
| filterFn: Function = () => true |
There was a problem hiding this comment.
Is there any benefit to passing filterFn as an argument? It looks like __findAll is only called in one place, so filterFn will always be isVueWrapper. So should we just remove the argument entirely?
Then we would not need filter at all.
There was a problem hiding this comment.
@xanf if we can resolve this one we can merge/release, can you take a look? Sorry on the delay, I've been mostly focused on V2.
There was a problem hiding this comment.
✔️ Done, sorry for delay, was focused on v1 -> v2 VTU migration :)
This one is actually used, I missed it :) It is used here: https://github.com/vuejs/vue-test-utils/pull/1910/files#diff-5c5637ddf50cba4f86e96ebb7854bb165fadf227f94d056fef19923be0a60e48R321
The reason for this is that we need to filter only component instances there :)
After releasing this I will do a big check-up if there are some low-hanging fruits in terms of v1/v2 behavior differences :)
91a0eff to
ee731ef
Compare
Allow findComponent / findAllComponents to be chained from DOM selector and allow CSS selectors to be used
ee731ef to
ed6fa54
Compare
2 participants
This PR is basically two features from
vue-test-utils-next:What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)