fix(test-utils): verify object not null for typeof - #1897
Merged
lmiller1990 merged 1 commit intoOct 29, 2021
Merged
Conversation
Using vue-test-utils may cause several messages of the sort ``` [Vue warn]: Error in render: "TypeError: Cannot read property 'template' of null" ``` Such messages stemmed from the `isComponentOptions` method call. It seems it received a null object and `typeof null` is object, so this error propagates to users of the library. This patch does not look for the reason a null object was sent in the first place, but it avoids the error propagation. close #1805
lmiller1990
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using vue-test-utils may cause several messages of the sort
Such messages stemmed from the
isComponentOptionsmethod call. Itseems it received a null object and
typeof nullis object, so thiserror propagates to users of the library.
This patch does not look for the reason a null object was sent in the
first place, but it avoids the error propagation.
close #1805