Skip to content

fix: fix support for some legacy registry servers - #5609

Merged
haoqunjiang merged 1 commit into
vuejs:devfrom
haoqunjiang:fix-metadata-json
Jun 24, 2020
Merged

fix: fix support for some legacy registry servers#5609
haoqunjiang merged 1 commit into
vuejs:devfrom
haoqunjiang:fix-metadata-json

Conversation

@haoqunjiang

Copy link
Copy Markdown
Member

Some registry servers do not recognize application/vnd.npm.install-v1+json
in the Accept header, so here we add application/json as fallback.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Some registry servers do not recognize `application/vnd.npm.install-v1+json`
in the Accept header, so here we add `application/json` as fallback.
@haoqunjiang

Copy link
Copy Markdown
Member Author

I've tested with verdaccio and the latest version of Sonatype Nexus3, both recognized the application/vnd.npm.install-v1+json header. But there may be some legacy versions doesn't support it, as reported in this issue: #5411 (comment)

@haoqunjiang
haoqunjiang merged commit 09cdf51 into vuejs:dev Jun 24, 2020
@haoqunjiang
haoqunjiang deleted the fix-metadata-json branch June 24, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant