feat: use @vue/compiler-sfc as a compiler for TS if available - #5170
Merged
Conversation
cexbrayat
force-pushed
the
fix/ts-vue-next
branch
from
February 9, 2020 18:32
8a413e6 to
e162f6e
Compare
9 tasks
Member
|
I think we can just add a file that shims the |
Member
|
All it needs is a path to a file that exports the |
cexbrayat
force-pushed
the
fix/ts-vue-next
branch
2 times, most recently
from
February 19, 2020 13:07
e2627da to
2b2f03a
Compare
Member
Author
|
@sodatea I updated the PR based on your idea.
We should now be able to remove |
cexbrayat
added a commit
to cexbrayat/vue-cli-plugin-vue-next
that referenced
this pull request
Feb 19, 2020
When vuejs/vue-cli#5170 lands in the CLI, we should be able to remove `vue-template-compiler` from the devDependencies. Fixes vuejs#5
haoqunjiang
requested changes
Feb 24, 2020
cexbrayat
force-pushed
the
fix/ts-vue-next
branch
from
February 24, 2020 10:32
2b2f03a to
7dd72b5
Compare
Member
Author
|
@sodatea I updated the PR with your feedback:
|
haoqunjiang
approved these changes
Feb 24, 2020
The `fork-ts-checker-webpack-plugin` is using `vue-template-compiler` by default, and this compiler is not the correct one to pick for vue-next. This commit tries to load `@vue/compiler-sfc` and falls back to `vue-template-compiler` if it does not find it.
cexbrayat
force-pushed
the
fix/ts-vue-next
branch
from
March 10, 2020 16:34
7dd72b5 to
4e64a09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: I'll let you decide but #5172 is probably a better alternative. See vuejs/vue-cli-plugin-vue-next#5 for more context
The
fork-ts-checker-webpack-pluginis usingvue-template-compilerby default, and this compiler is not the correct one to pick for vue-next. This commit tries to load@vue/compiler-sfcand falls back tovue-template-compilerif it does not find it.It also bumps the
fork-ts-checker-webpack-pluginto use v3.1.3What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: