Use a single websocket connection for HMR - #5069
Merged
Merged
Conversation
lbogdan
commented
Jan 10, 2020
lbogdan
force-pushed
the
fix/hmr-websocket
branch
from
January 10, 2020 13:33
bf6cbf2 to
d8eb35e
Compare
Contributor
Author
|
This should be ready for review. Things I'm not 100% sure:
|
lbogdan
marked this pull request as ready for review
January 10, 2020 13:54
lbogdan
force-pushed
the
fix/hmr-websocket
branch
from
January 10, 2020 14:21
d8eb35e to
d2045b9
Compare
haoqunjiang
approved these changes
Jan 13, 2020
mactanxin
pushed a commit
to mactanxin/vue-cli
that referenced
this pull request
Feb 11, 2020
* fix(hmr-websocket): add failing test * fix(hmr-websocket): set injectClient to false, as we inject our own client * fix(hmr-websocket): change test project name
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4947 , see that for details.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)