Skip to content

test: remove type in errors - #2966

Merged
FloEdelmann merged 12 commits into
vuejs:masterfrom
9romise:cleanup-test
Nov 27, 2025
Merged

test: remove type in errors#2966
FloEdelmann merged 12 commits into
vuejs:masterfrom
9romise:cleanup-test

Conversation

@9romise

@9romise 9romise commented Nov 22, 2025

Copy link
Copy Markdown
Collaborator

@changeset-bot

changeset-bot Bot commented Nov 22, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 49352c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread tests/lib/rules/no-template-shadow.js
Comment thread tests/lib/rules/prop-name-casing.js
Comment thread tests/lib/rules/require-direct-export.js
Comment thread tests/lib/rules/require-render-return.js
Comment thread tests/lib/rules/static-class-names-order.js
Comment thread tests/lib/utils/vue-component.js
Comment thread tests/lib/rules/no-restricted-class.js
Comment thread tests/lib/rules/no-reserved-component-names.js
Comment thread tests/lib/rules/require-name-property.js
@FloEdelmann

Copy link
Copy Markdown
Member

FYI: Lint errors fixed in #2981, so I updated your branch with that.

@9romise
9romise requested a review from FloEdelmann November 27, 2025 11:39
@9romise

9romise commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator Author

Just a heads-up: there are other test cases in the repository aren’t verifying the location info.

@FloEdelmann FloEdelmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

Just a heads-up: there are other test cases in the repository aren’t verifying the location info.

Yeah, I know. I just didn't want to make the tests weaker by removing type and not adding location. Ideally we'd add the location everywhere but that's clearly out of scope for this PR 😅

@FloEdelmann
FloEdelmann merged commit 7523350 into vuejs:master Nov 27, 2025
15 checks passed
@9romise
9romise deleted the cleanup-test branch November 27, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants