perf(compiler-core): use binary-search to get the line and column.

[skyfeiz]

Problem Description

• Given: this.newlines is a strictly increasing array.
• Direct traversal to obtain the newLineIndex corresponding to the critical value index.
• When the array length is large, the performance is significantly worse compared to binary-search.

Solution

• If the array length is greater than 100, use binary-search to obtain the result.
• If the array length is less than or equal to 100, obtain the result directly via traversal.

Summary by CodeRabbit

• Refactor
  • Optimized the compiler core's position calculation algorithm to improve overall system performance, particularly benefiting large files that contain numerous line breaks and require frequent position lookups during compilation
  • Enhanced the Position object data structure returned from position queries to include an additional offset field, providing developers with more granular and comprehensive position tracking information

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The getPos function in the tokenizer is optimized to use a hybrid approach: binary search for large newline counts (>100) and linear scan for smaller counts. The Position return type is augmented to include a new offset field representing the index, alongside the existing line and column fields.

Changes

Cohort / File(s)	Summary
Tokenizer position optimization and type augmentation packages/compiler-core/src/tokenizer.ts	Updated getPos logic to use binary search for newline lookups when count exceeds 100, otherwise linear scan. Position object now includes offset field.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Binary search correctness: Verify the binary search implementation correctly locates the relevant newline index across edge cases
• Position field computation: Ensure offset, line, and column are computed consistently and accurately
• Caller compatibility: Check all call sites of getPos to confirm they handle or safely ignore the new offset field in the returned object

Poem

🐰 A tokenizer so spry, with binary wings to fly,
Faster seeks the newlines high, no linear scan nearby!
Offset joins the line and column in this change—
Position objects now with range,
Optimization brought with grace! 📍✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the primary optimization: using binary search instead of linear traversal to compute line and column numbers, which directly aligns with the main performance improvement in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	103 kB	39 kB	35.1 kB
vue.global.prod.js	161 kB (+113 B)	59 kB (+61 B)	52.5 kB (+31 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.9 kB	18.3 kB	16.8 kB
createApp	55 kB	21.4 kB	19.6 kB
createSSRApp	59.3 kB	23.1 kB	21.1 kB
defineCustomElement	60.6 kB	23.1 kB	21.1 kB
overall	69.3 kB	26.6 kB	24.3 kB

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14222

npm i https://pkg.pr.new/@vue/compiler-core@14222

yarn add https://pkg.pr.new/@vue/compiler-core@14222.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14222

npm i https://pkg.pr.new/@vue/compiler-dom@14222

yarn add https://pkg.pr.new/@vue/compiler-dom@14222.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14222

npm i https://pkg.pr.new/@vue/compiler-sfc@14222

yarn add https://pkg.pr.new/@vue/compiler-sfc@14222.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14222

npm i https://pkg.pr.new/@vue/compiler-ssr@14222

yarn add https://pkg.pr.new/@vue/compiler-ssr@14222.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14222

npm i https://pkg.pr.new/@vue/reactivity@14222

yarn add https://pkg.pr.new/@vue/reactivity@14222.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14222

npm i https://pkg.pr.new/@vue/runtime-core@14222

yarn add https://pkg.pr.new/@vue/runtime-core@14222.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14222

npm i https://pkg.pr.new/@vue/runtime-dom@14222

yarn add https://pkg.pr.new/@vue/runtime-dom@14222.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14222

npm i https://pkg.pr.new/@vue/server-renderer@14222

yarn add https://pkg.pr.new/@vue/server-renderer@14222.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14222

npm i https://pkg.pr.new/@vue/shared@14222

yarn add https://pkg.pr.new/@vue/shared@14222.tgz

vue

pnpm add https://pkg.pr.new/vue@14222

npm i https://pkg.pr.new/vue@14222

yarn add https://pkg.pr.new/vue@14222.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14222

npm i https://pkg.pr.new/@vue/compat@14222

yarn add https://pkg.pr.new/@vue/compat@14222.tgz

commit: 9b6c82e

[edison1105]

/ecosystem-ci run

[vue-bot]

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	❌ failure	❌ failure
radix-vue	✅ success	✅ success
pinia	✅ success	✅ success
nuxt	✅ success	✅ success
primevue	✅ success	✅ success
quasar	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vuetify	❌ failure	❌ failure
vue-i18n	❌ failure	❌ failure
vue-simple-compiler	✅ success	✅ success
test-utils	✅ success	✅ success
vant	✅ success	✅ success
vue-macros	❌ failure	❌ failure
vitepress	✅ success	✅ success
router	✅ success	✅ success
vueuse	✅ success	✅ success