Skip to content

Rename imported package alias - #510

Merged
volcano-sh-bot merged 1 commit into
volcano-sh:masterfrom
hzxuzhonghu:pkg-alias
Nov 6, 2019
Merged

Rename imported package alias#510
volcano-sh-bot merged 1 commit into
volcano-sh:masterfrom
hzxuzhonghu:pkg-alias

Conversation

@hzxuzhonghu

Copy link
Copy Markdown
Member

This is kind of clean code.

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 6, 2019
@TravisBuddy

Copy link
Copy Markdown

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2c4c3bd0-0062-11ea-8767-d53e6939ac53

@k82cn

k82cn commented Nov 6, 2019

Copy link
Copy Markdown
Member

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@TravisBuddy

Copy link
Copy Markdown

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 701e15b0-008d-11ea-8767-d53e6939ac53

@volcano-sh-bot
volcano-sh-bot merged commit 2d80438 into volcano-sh:master Nov 6, 2019
@hzxuzhonghu
hzxuzhonghu deleted the pkg-alias branch November 7, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants