[release-1.13] Fix shared mutable objects in scheduler snapshot clones

[volcano-sh-bot]

This is an automated cherry-pick of #5086

None

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where scheduler snapshots and cloned objects were inadvertently sharing mutable underlying data structures. By introducing DeepCopy() calls at key points during object cloning and snapshotting, the changes ensure that these operations produce truly independent copies. This prevents unexpected side effects and data corruption that could arise from modifications to what were intended to be isolated copies, thereby enhancing the stability and predictability of the scheduler's state management.

Highlights

• TaskInfo Cloning: Ensured that the Pod object within a TaskInfo is deep-copied when TaskInfo is cloned, preventing unintended modifications to shared Pod instances.
• NamespaceInfo Snapshotting: Implemented deep-copying for each ResourceQuotaStatus entry within the QuotaStatus map when creating a NamespaceInfo snapshot, addressing potential issues with shared mutable quota data.
• NodeInfo Cloning: Modified NodeInfo cloning to deep-copy the underlying Node object, ensuring that modifications to the cloned NodeInfo's Node do not affect the original Node.
• QueueInfo Cloning: Updated QueueInfo cloning to deep-copy the Queue object, preventing shared mutable state for queue configurations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/scheduler/api/job_info.go
  • The Pod field in TaskInfo's Clone() method now uses ti.Pod.DeepCopy() to create an independent copy.
• pkg/scheduler/api/namespace_info.go
  • The Snapshot() method for NamespaceCollection now iterates through n.QuotaStatus and deep-copies each v1.ResourceQuotaStatus entry into a new map copiedQuotaStatus before assigning it to the QuotaStatus field of the new NamespaceInfo.
• pkg/scheduler/api/node_info.go
  • The NodeInfo's Clone() method now initializes the new NodeInfo with NewNodeInfo(ni.Node.DeepCopy()), ensuring the underlying Node object is deep-copied.
• pkg/scheduler/api/queue_info.go
  • The Queue field in QueueInfo's Clone() method now uses q.Queue.DeepCopy() to create a distinct copy.

Activity

• This is an automated cherry-pick from PR Fix shared mutable objects in scheduler snapshot clones #5086, indicating a backport of an existing fix.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses critical issues related to shared mutable objects in scheduler snapshot clones. The changes across job_info.go, namespace_info.go, node_info.go, and queue_info.go correctly replace shallow copies with deep copies for fields that are pointers or reference types. Specifically, TaskInfo.Pod, NamespaceCollection.QuotaStatus, NodeInfo.Node, and QueueInfo.Queue are now properly deep-copied in their respective Clone or Snapshot methods. These changes are essential for preventing data races and ensuring state consistency within the scheduler. The fixes are well-implemented and directly address the problem of shared state.

[JesseStutler]

/approve
/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JesseStutler
Once this PR has been reviewed and has the lgtm label, please assign hwdef for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment