[release-1.14] Fix shared mutable objects in scheduler snapshot clones

[volcano-sh-bot]

This is an automated cherry-pick of #5086

None

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where scheduler snapshot clones were not performing deep copies of certain nested objects, leading to shared mutable state. By introducing DeepCopy() calls at various points within the cloning and snapshotting mechanisms for Pod, Node, Queue, and ResourceQuotaStatus objects, this change ensures that all cloned data structures are truly independent. This enhancement improves the robustness and predictability of the scheduler's state management by preventing unintended side effects when working with cloned scheduler components.

Highlights

• TaskInfo Cloning: Ensured that the Pod object within a TaskInfo is deep copied when TaskInfo.Clone() is called, preventing shared mutable state.
• NamespaceInfo Snapshotting: Implemented deep copying for the QuotaStatus map and its ResourceQuotaStatus values when creating a NamespaceInfo snapshot from a NamespaceCollection, ensuring independent quota status.
• NodeInfo Cloning: Modified NodeInfo.Clone() to perform a deep copy of the underlying Node object, preventing unintended modifications to the original node data.
• QueueInfo Cloning: Updated QueueInfo.Clone() to deep copy the Queue object, ensuring that cloned queue information is independent of the original.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/scheduler/api/job_info.go
  • Modified TaskInfo.Clone() to deep copy the Pod object.
• pkg/scheduler/api/namespace_info.go
  • Modified NamespaceCollection.Snapshot() to deep copy the QuotaStatus map and its ResourceQuotaStatus values.
• pkg/scheduler/api/node_info.go
  • Modified NodeInfo.Clone() to deep copy the Node object.
• pkg/scheduler/api/queue_info.go
  • Modified QueueInfo.Clone() to deep copy the Queue object.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses potential data corruption issues by fixing shared mutable objects in several scheduler snapshot/clone functions. The changes correctly introduce deep copies for Pod, Node, and Queue objects during cloning operations, which is a crucial improvement for scheduler stability. However, the change in pkg/scheduler/api/namespace_info.go for deep-copying QuotaStatus appears to introduce a compilation error. I've provided a critical comment with a suggested fix for this issue.

[JesseStutler]

/approve
/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JesseStutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [JesseStutler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment