release-1.14: Update KUBE_VERSION to 1.34.1 in webhook-manager Dockerfile - #5063
Conversation
Summary of ChangesHello @hajnalmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a version discrepancy in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
volcano-sh-bot
added
the
size/XS
hajnalmt
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the KUBE_VERSION in the webhook-manager Dockerfile to 1.34.0. This change aligns the version of the kubectl binary inside the container with the supported Kubernetes version, fixing a version skew issue. The change is correct and resolves the issue described.
The Kubernetes 1.34 adaptation (volcano-sh#4704) missed updating the KUBE_VERSION ARG used for downloading kubectl in the webhook-manager Dockerfile. Signed-off-by: Hajnal Máté <hajnalmt@gmail.com>
01fd48a to
48dd26f
Compare
hajnalmt
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
f744059
into
volcano-sh:release-1.14
3 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
Updates the
KUBE_VERSIONARG in the webhook-manager Dockerfile from1.32.0to1.34.1. This ARG controls which version ofkubectlis downloaded into the webhook-manager image. It was missed during the Kubernetes 1.34 adaptation in #4704, leaving the image with a stale kubectl binary two major versions behind.The corresponding fix for master (
1.35.0) has been filed as #5062.Which issue(s) this PR fixes:
Fixes an oversight in #4704.
Special notes for your reviewer:
The webhook-manager Dockerfile downloads
kubectlat build time usingKUBE_VERSION. This was last updated during the k8s 1.32 adaptation and was not bumped in either the 1.34 or 1.35 adaptation PRs.Does this PR introduce a user-facing change?