[release-1.14] fix: remove duplicated session close call

[volcano-sh-bot]

This is an automated cherry-pick of #5055

[gemini-code-assist]

Summary of Changes

Hello @volcano-sh-bot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the scheduler framework by eliminating a redundant call to OnSessionClose() during session closure. This change ensures that the session cache is handled correctly and avoids potential double-closure or related side effects, improving the stability of the release-1.14 branch.

Highlights

• Bug Fix: Addressed a duplicated call to ssn.cache.OnSessionClose() within the CloseSession function, preventing potential double-closure issues.
• Code Redundancy: Removed an unnecessary invocation of OnSessionClose() to streamline session termination logic and improve code clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/scheduler/framework/framework.go
  • Removed a duplicated call to ssn.cache.OnSessionClose() in the CloseSession function.

Activity

• This pull request is an automated cherry-pick of fix: remove duplicated session close call #5055, indicating it's a backport of an existing fix.
• The pull request was authored by volcano-sh-bot, suggesting automated creation for release branch maintenance.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a duplicated function call in pkg/scheduler/framework/framework.go. The change removes a call to ssn.cache.OnSessionClose() from the CloseSession function. This call is redundant because the closeSession function, which is called right before, already performs this action. The removal is correct and resolves the duplication.

[JesseStutler]

/approve
/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JesseStutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [JesseStutler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment