fix(cli): remove stale global package shims#1765
Merged
fengmk2 merged 7 commits intoJun 5, 2026
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Author
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
vp install -gflow backs up and replaces the package installation directory, then writes shims for binaries declared by the newly installed package. If a package update removes a binary from itspackage.json#bin, the old shim and per-binary config can remain inVP_HOME/binandVP_HOME/bins. It seems introduced in #524.This PR removes stale managed binary shims during successful global package reinstall. It compares the package's previous metadata and bin configs against the newly installed bin list, then deletes shims/configs for binaries that the package no longer declares.
This keeps existing behavior where
vp install -gdoes not remove shims before invoking npm; cleanup only happens after the new package has installed and its current binaries have been finalized.This PR also adds a global snapshot case with two local package fixtures that share the same package name: v1 declares two bins, v2 declares one bin, and the test verifies the removed bin's shim and config are gone after reinstall.
🤖 Generated with Codex