[ROCm][CI] Stabilize the sqrt-softplus top-k tie oracle - #54403
Draft
AndreasKaratzas wants to merge 1 commit into
Draft
[ROCm][CI] Stabilize the sqrt-softplus top-k tie oracle#54403AndreasKaratzas wants to merge 1 commit into
AndreasKaratzas wants to merge 1 commit into
Conversation
Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
AndreasKaratzas
force-pushed
the
akaratza_topk_softplus_tie_break
branch
from
August 30, 2026 08:13
f82a3aa to
7aae9a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.topkselection with stable descendingargsort.The
MI355 MoE Shard 3group in AMD CI build 12440 reported one mismatched expert in the BF16 384-expert case. Formal bisection found no responsible PR in the nightly window because the relevant source blobs were identical atf956e1c343dc63720b50c01209bd5ada6d8589a2and the failing tip, while the exact node also passed repeatedly. The failure was an oracle ambiguity:torch.topkdoes not specify which equal-scored index wins, whereas the fused kernel intentionally selects the lower expert ID. Making the reference ordering explicit removes that nondeterminism without changing production behavior.