Skip to content

build: use JSON import attributes instead of readFIleSync in rolldown configs #23251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 1 commit into from
Aug 13, 2026
Merged

build: use JSON import attributes instead of readFIleSync in rolldown configs #23251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/vite/rolldown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { readFileSync, writeFileSync } from 'node:fs'
import { writeFileSync } from 'node:fs'
import path from 'node:path'
import MagicString from 'magic-string'
import type { Plugin } from 'rolldown'
import { defineConfig } from 'rolldown'
import { ImportType, init, parse } from 'es-module-lexer'
import licensePlugin from './rollupLicensePlugin'
import pkg from './package.json' with { type: 'json' }

// eslint-disable-next-line n/no-unsupported-features/node-builtins
const dirname = import.meta.dirname
const pkg = JSON.parse(
readFileSync(new URL('./package.json', import.meta.url)).toString(),
)

const disableSourceMap = !!process.env.DEBUG_DISABLE_SOURCE_MAP

const envConfig = defineConfig({
Expand Down
6 changes: 1 addition & 5 deletions packages/vite/rolldown.dts.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { readFileSync } from 'node:fs'
import { builtinModules } from 'node:module'
import { defineConfig } from 'rolldown'
import type {
Expand All @@ -13,16 +12,13 @@ import { dts } from 'rolldown-plugin-dts'
import { parse as parseWithBabel } from '@babel/parser'
import { walk } from 'estree-walker'
import MagicString from 'magic-string'
import pkg from './package.json' with { type: 'json' }

type Directive = ESTree.Directive
type ModuleExportName = ESTree.ModuleExportName
type Program = ESTree.Program
type Statement = ESTree.Statement

const pkg = JSON.parse(
readFileSync(new URL('./package.json', import.meta.url)).toString(),
)

const external = [
/^node:*/,
/^vite\//,
Expand Down
Loading