fix: last timeout in queueTrigger() never clears map - #7964
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7964 +/- ##
==========================================
+ Coverage 80.94% 80.98% +0.03%
==========================================
Files 116 116
Lines 7467 7472 +5
Branches 1816 1817 +1
==========================================
+ Hits 6044 6051 +7
+ Misses 1423 1421 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EventTarget.queueTrigger() method contains a timeout code that should clear map when map.size === 0. However, It looks like
this statement will never trigger right now because the map has always size value bigger than 0.
Specific Changes proposed
The last timeout should delete the type from the map.
Requirements Checklist