refactor: instructor_llm_factory merge with llm_factory - #2382
Merged
Conversation
anistark
force-pushed
the
refactor/llm-factory
branch
from
October 24, 2025 13:03
b79406a to
e5985d3
Compare
instructor_llm_factory merge with llm_factory
anistark
added a commit
that referenced
this pull request
Nov 17, 2025
Consolidates dual LLM factories into a single, explicit `llm_factory()`
API. Removes `instructor_llm_factory()` entirely.
- Unified `llm_factory()`: Single factory supporting multiple LLM
providers (OpenAI, Anthropic, Cohere, Google, LiteLLM)
- Requires explicit parameters: `model`, `provider`, `client`
- Returns: `InstructorBaseRagasLLM` (structured outputs only)
- Clear error messages for missing parameters
- Removed `instructor_llm_factory()`: Deleted entirely (~97 lines)
- Functionality merged into unified `llm_factory()`
- Removed from public exports
**Before:**
```py
from ragas.llms import instructor_llm_factory
llm = instructor_llm_factory("openai", model="gpt-4o", client=client)
```
**After:**
```py
from ragas.llms import llm_factory
llm = llm_factory("gpt-4o", client=client) # provider defaults to "openai"
```
```py
llm = llm_factory("gpt-4o-mini")
from openai import OpenAI
client = OpenAI(api_key='...')
llm = llm_factory('gpt-4o-mini', client=client)
```
This is a **breaking change** for the public API, but justified because:
1. Old text-only factory was already deprecated
2. All new metrics require structured outputs (InstructorLLM)
3. Unified API is simpler and more maintainable
4. Clear error messages guide easy migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates dual LLM factories into a single, explicit
llm_factory()API. Removesinstructor_llm_factory()entirely.Changes
Core Changes
Unified
llm_factory(): Single factory supporting multiple LLM providers (OpenAI, Anthropic, Cohere, Google, LiteLLM)model,provider,clientInstructorBaseRagasLLM(structured outputs only)Removed
instructor_llm_factory(): Deleted entirely (~97 lines)llm_factory()API Change
Before:
After:
Migration for Users
Notes
This is a breaking change for the public API, but justified because: