Skip to content

Deprecation warnings for LLMs and Prompts - #2253

Merged
anistark merged 2 commits into
vibrantlabsai:mainfrom
rhlbhatnagar:rbhatnagar/add_deprecation_warnings_for_prompts+llms
Sep 24, 2025
Merged

Deprecation warnings for LLMs and Prompts#2253
anistark merged 2 commits into
vibrantlabsai:mainfrom
rhlbhatnagar:rbhatnagar/add_deprecation_warnings_for_prompts+llms

Conversation

@rhlbhatnagar

@rhlbhatnagar rhlbhatnagar commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Deprecation warnings for LLMs and Prompts

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 5, 2025
@rhlbhatnagar

Copy link
Copy Markdown
Contributor Author

@anistark please review + merge

Comment thread src/ragas/prompt/pydantic_prompt.py
Comment thread src/ragas/utils.py
@minorun365

Copy link
Copy Markdown
Contributor

@anistark
Hi, how should we do when we use AWS Bedrock for LLM & embeddings if LangChainLLMWrapper deprecated?

@anistark

anistark commented Sep 24, 2025

Copy link
Copy Markdown
Member

@anistark Hi, how should we do when we use AWS Bedrock for LLM & embeddings if LangChainLLMWrapper deprecated?

@minorun365
Wrappers are deprecated. Use factories instead:

bedrock_llm = llm_factory(
      provider="bedrock",
      model="anthropic.claude-3-sonnet-20240229-v1:0",
      region_name="us-east-1"
)

For embeddings,

bedrock_embeddings = embedding_factory(
      provider="bedrock",
      model="amazon.titan-embed-text-v1",
      region_name="us-east-1"
)

@minorun365

Copy link
Copy Markdown
Contributor

@anistark
Thank you! I tried instructor_llm_factory but ValueError when using bedrock on the newest Ragas 🤔
https://github.com/explodinggradients/ragas/blob/main/src/ragas/llms/base.py#L688

@anistark

Copy link
Copy Markdown
Member

@anistark Thank you! I tried instructor_llm_factory but ValueError when using bedrock on the newest Ragas 🤔 https://github.com/explodinggradients/ragas/blob/main/src/ragas/llms/base.py#L688

Please open a separate issue for it. We can take a look there. :)

@anistark
anistark merged commit 45fc465 into vibrantlabsai:main Sep 24, 2025
17 checks passed
anistark pushed a commit that referenced this pull request Nov 17, 2025
Deprecation warnings for LLMs and Prompts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants