Add "Vary: Origin" header to CORS preflight responses - #2882
Merged
Conversation
Member
Author
|
@pmlopes any chance for you to take a look? |
See vert-x3#2880 The preflight branch (OPTIONS + Access-Control-Request-Method) was missing the "Vary: Origin header", while the non-preflight and no-origin branches already included it. Without it, HTTP caches may serve a preflight response with the wrong Access-Control-Allow-Origin when multiple origins are allowed or credentials are enabled. See https://fetch.spec.whatwg.org/#cors-protocol-and-http-caches Some portions of this content were created with the assistance of Claude Code. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
May 19, 2026
See #2880 The preflight branch (OPTIONS + Access-Control-Request-Method) was missing the "Vary: Origin header", while the non-preflight and no-origin branches already included it. Without it, HTTP caches may serve a preflight response with the wrong Access-Control-Allow-Origin when multiple origins are allowed or credentials are enabled. See https://fetch.spec.whatwg.org/#cors-protocol-and-http-caches Some portions of this content were created with the assistance of Claude Code. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
May 19, 2026
…#2894) See #2880 The preflight branch (OPTIONS + Access-Control-Request-Method) was missing the "Vary: Origin header", while the non-preflight and no-origin branches already included it. Without it, HTTP caches may serve a preflight response with the wrong Access-Control-Allow-Origin when multiple origins are allowed or credentials are enabled. See https://fetch.spec.whatwg.org/#cors-protocol-and-http-caches Some portions of this content were created with the assistance of Claude Code. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2880
The preflight branch (OPTIONS + Access-Control-Request-Method) was missing the "Vary: Origin header", while the non-preflight and no-origin branches already included it.
Without it, HTTP caches may serve a preflight response with the wrong Access-Control-Allow-Origin when multiple origins are allowed or credentials are enabled.
See https://fetch.spec.whatwg.org/#cors-protocol-and-http-caches
Some portions of this content were created with the assistance of Claude Code.