Rethrow error thrown from withAsyncTestingChannel closure - #606
Merged
Conversation
Currently, when the closure of `withAsyncTestingChannel` throws, the error is just swallowed silently and the test passes. Actually rethrow it so the test fails
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 77.24% 77.26% +0.01%
==========================================
Files 137 137
Lines 10612 10612
==========================================
+ Hits 8197 8199 +2
+ Misses 2415 2413 -2 🚀 New features to boost your workflow:
|
ptoffy
approved these changes
Jul 27, 2026
gwynne
requested changes
Jul 28, 2026
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
gwynne
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the closure of
withAsyncTestingChannelthrows, the error is just swallowed silently and the test passes. Actually rethrow it so the test fails