Conversation
Fix typos in documentation: - Corrected "*Faram* Gymnasium Environments" to "*Farama* Gymnasium Environments". - Fixed "Externally *exited* synchronous motor (EESM)" to "Externally *excited* synchronous motor (EESM)". - Updated "Journal of Open *Sorce* Software (JOSS)" to "Journal of Open *Source* Software (JOSS)".
…ttps://github.com/upb-lea/gym-electric-motor into add-further-automated-testing-of-existing-features
Update README.md
There is an error with gem-control and finite 3 phase environments.
263 examples gymnasium v1
…-existing-features test for classic controllers, dc motor, dcExternallyExcited motor
fixed the changelog after the merge
Cont-CC-SIXPMSM-v0 environment ready- need critical reviews
Completed SIXPMSM environments
…b" and created new file for finite current control
…ented comments on pmsm_fcs_mpc_dq_current_control.ipynb file
…utilities and improve prediction logic - Replaced manual abc → αβ → dq voltage transformations with environment's native method: - Updated voltage vector table to use finite set directly from the environment via: - Now storing and returning subaction **indices** instead of full abc voltage vectors for better integration and comparison - Updated epsilon handling in prediction loop: - Epsilon is now incremented as - dq-transformation uses averaged value: - Replaced hardcoded max_depth with (renamed from for clarity) Previously, I was doing manual calculations: converting abc voltages to αβ and then dq using custom logic. Now all transformations use the environment's own coordinate conversion function and finite action space, making the controller more accurate and modular. Thanks again for the helpful feedback!
…of u_abc from subaction state
…rap around GymElectricMotorAdapter class. 2)updated the MPC controller file to process directly from environment,PMSM works.
…troller.make - Added w_d and w_q parameters to MPCCurrentController - Updated cost function to use weighted errors - Modified GemController.make to forward extra kwargs into MPC
* Updated gem-elecrtric-motor with gem-control docs * Delete src/debug.ipynb * Delete eesm file * Add debug.ipynb to .gitignore * test * deletion of readme file * Syntax changed - 2 files * try to fix the index.rst * further changes to the index.rst and delete unnecessary .rst files * fixed a typo in the file name * change in the index.rst * fix gem_control.rst * delete the not necessary parts folder and try to add some text to gem_controllers.rst to generate at least the html page. * fix error in the do build * try another path to enable the full doc build * try to exclude block_diagrams/block_diagrams because of the warning in the build log * deleted the parts of gem control in the gem docs and revert the change in the gem_controllers.rst * try some fix * Added the title to all rst files to fix the missing link in the docs * add installation of block diagramms into the doc building process * add git to the build process of the docs * try to fix install of Control Block Diagramms in the doc build process * fix for missing git command * try to fix import error of the gem-control functions * revert change because of other error * checked all warning logs in sphinx doc * try to import using tk * installed control package * exclude JOSS error * installed ipython * made some changes to build and conf file * added extensions * restored confy file * pre-build command change * added && * Import error of matlab plot * tried command * missing os libs * print hidden log * application error * python traceback * bypass wrapper * reverting the recent changes * compatible version * changing libs error * adding mdinclude * installing mdinclude * reverting the changes in build * testing mdinclude * removing m2r2 * making docutils as 0.19 * pinning older theme * changing theme in confy * correcting theme package name * editing the build * avoiding sphinx version * pinning version as 4.5.0 * fixing error sphinxcontrib.applehelp * pinning docutils * updating sphinx theme * correcting incompatible errors * pinning older sphinx * using wrapper action * updating docutils * removing sphinx action * merge block and build docs * fixing static missing error * fixing automethid error * change in operation point rst * using preamble instead of latex * remove the localdir message * fixing the attribute in exter_dc rst * fixing docstring * fixing block errors * using autodoc on module * toctree listing * fixing module path * Fixing GEM controller * Fixing mismatching file name * Fixing the review comments * Fixing constraint * fixing build doc * fixing current module error * suppressing warnings * renaming readme file * removing waring * Re-enable the rst * fixing upstream docstrings * removing warnings * Add missing files from the sixphase again * fixing some names of the envs * removed an unnecessary file * fixing tree --------- Co-authored-by: annava1 <annavall@campus.uni-paderborn.de> Co-authored-by: mounica3003 <mounicav3003@gmail.com>
Small update of cookbook and examples fix issue #287
…ated-model-predictive-current-control-to-gem-control # Conflicts: # examples/model_predictive_controllers/pmsm_mpc_dq_current_control.ipynb
…rge of the changes in this branch.
…dictive-current-control-to-gem-control 274 automated finite control set current control for PMSM and SynRM is available but runs not with superimposed controllers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get ready for a new release