feat: add local package preset support - #451
Merged
Merged
Conversation
|
|
userquin
changed the title
antfu
reviewed
Nov 27, 2023
antfu
approved these changes
Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We cannot use package presets, it seems we removed the
presetsoption.This PR includes:
packagePresetsoptions to allow use local installed packages as presetsmagic-stringdetect-browser-espackage inexamples/vite-svelte, check readmeAbout the note in the readme, check
Additonal contextbelow.Linked Issues
related to issue #446 and PR #450
Additional context
@mdi/jsis not working,mllyunable to extract module exports, it resolves to cjs and returns an empty array: tested on my local in Svelte (type module) example: