Namespace passing in http header - #1179
Merged
LucioFranco merged 91 commits intoApr 22, 2024
Merged
Conversation
…-passing-and-auth
Builds of arm images are hanging/crashing
…atabase#1300) This reverts commit 342e4c3.
* bottomless: upgrade s3 sdk to 1.0 * fix behavior version
* server: add query stats to hrana responses * update spec with stats * remove unused import * fix snapshot * more snapshots * add stats to legacy api * address comments
Old implementation could never finish if the write is faster than time needed to do two round-trips to primary. For example it's enough to have a write every 200ms to make sync never finish if it's done in embedded replica in Sydney if the primary and the writer are in the US. Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
* server: add `query_duration_ms` stats to query res * hrana: default new stats fields
This reverts commit a86b89d.
LucioFranco
approved these changes
Apr 22, 2024
Contributor
|
This is a breaking change for the platform. The FYI, I'll patch that to base64 decode the header value. |
Contributor
|
update: the header should be base64 encoded |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
Following the work @shopifyski did to add the ability to set namespace via header for `RemoteReplica` in #1179 this adds similar support for `Remote` connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding alternative to namespace inference from hostname prefix.
Utilizing NAMESPACE_METADATA_KEY to transfer namespace.
Tested with remote_sync example:
cc: @LucioFranco @jeremywrowe @jameswritescode