perf: use built-in sorted() in DsList.sort_list#35
Open
m-truscott wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the hand-rolled O(n²) bubble sort in
DsList.sort_listwith Python's built-insorted(), improving performance and readability.Changes
sorted(v)insrc/llm_benchmark/datastructures/dslist.pyValidation
Validation commands configured for this project (run to verify the change is safe):
uv pip install poetry && python -m poetry installpython -m poetry run pytest --benchmark-skip tests/python -m poetry run pytest --benchmark-only tests/Notes
sorted()returns a new list, preserving the original non-mutating behaviour of the previous implementation. Both produce identical ascending-order output forList[int].changeset_id: ec82b078-0eba-4148-bb3b-c831e6a77c1d
Trigger Artemis Fix Agent to iterate on comments left on your PR
@artemis-fix-agentin a new comment — this will be your trigger comment. Optionally, add further instructions you want Artemis to act on.Example trigger comment:
Artemis will pick up all existing PR comments automatically. Note that each time you tag
@artemis-fix-agent, a separate, parallel fix attempt will be kicked off, so only tag Artemis once you're ready to start.