Skip to content

Request Timeout to include DNS and Socket connection - #179

Merged
tulios merged 2 commits into
tulios:masterfrom
ollelindeman:feature/timeouts-include-socket-connect
Mar 25, 2020
Merged

Request Timeout to include DNS and Socket connection#179
tulios merged 2 commits into
tulios:masterfrom
ollelindeman:feature/timeouts-include-socket-connect

Conversation

@ollelindeman

Copy link
Copy Markdown
Contributor

[Work In Progress]

@tulios

tulios commented Mar 25, 2020

Copy link
Copy Markdown
Owner

@ollelindeman can you also add this to the HTTP config:

onRequestWillStart(requestParams)
onRequestSocketAssigned(requestParams)
onSocketLookup(requestParams)
onSocketConnect(requestParams)
onSocketSecureConnect(requestParams)
onResponseReadable(requestParams)
onResponseEnd(requestParams)

They were added a while back, but we forgot to add a default null value; this is mainly to "document" their existence.

Comment thread src/gateway/http.js Outdated
@tulios

tulios commented Mar 25, 2020

Copy link
Copy Markdown
Owner

The build is green, there is something wrong with the travis integration
https://travis-ci.org/github/tulios/mappersmith/builds/666839040

@tulios
tulios merged commit 152a97d into tulios:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants