Fix trace file deletion paths - #98
Open
liurenfeng94-ops wants to merge 1 commit into
Open
Conversation
|
We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:
Please review these AI-assisted contribution guidelines and update this contribution if needed. If this was flagged in error, we apologise! 😳 Just let us know. 🙏 |
Author
|
Thanks for the heads-up — I rewrote the description in my own words. The change is just the cleanup path fix plus a small helper/test split so the path behavior is covered cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small path bug in trace cleanup.
When deleting all trace JSON files, the code read entries from the trace directory but called
statSync(file)on the bare file name. That only works if the current process happens to be in the trace directory. This changes cleanup to build absolute paths before checking/deleting files.The path selection is split into a tiny helper so it can be tested without starting VS Code.
Validation: