Skip to content

Fix trace file deletion paths - #98

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-trace-delete-path
Open

Fix trace file deletion paths#98
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-trace-delete-path

Conversation

@liurenfeng94-ops

@liurenfeng94-ops liurenfeng94-ops commented Jul 28, 2026

Copy link
Copy Markdown

Fixes a small path bug in trace cleanup.

When deleting all trace JSON files, the code read entries from the trace directory but called statSync(file) on the bare file name. That only works if the current process happens to be in the trace directory. This changes cleanup to build absolute paths before checking/deleting files.

The path selection is split into a tiny helper so it can be tested without starting VS Code.

Validation:

  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@liurenfeng94-ops

Copy link
Copy Markdown
Author

Thanks for the heads-up — I rewrote the description in my own words. The change is just the cleanup path fix plus a small helper/test split so the path behavior is covered cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant