Label trace diagnostics as trace metrics - #95
Open
liurenfeng94-ops wants to merge 2 commits into
Open
Conversation
|
We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:
Please review these AI-assisted contribution guidelines and update this contribution if needed. If this was flagged in error, we apologise! 😳 Just let us know. 🙏 |
Author
|
Thanks for the note — I rewrote the description to be more direct. The change itself is small: it makes the trace diagnostics explicitly read as trace metrics, and it tags the diagnostics so they are clearly separate from the realtime measurements. I can walk through the code path end to end if helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up because the trace diagnostics looked too similar to the realtime metrics, so I made the trace ones say Trace check ms and marked the diagnostics source/code explicitly in VS Code. I also pulled the message formatting into a small helper and covered it with tests.
Validation: