Skip to content

Label trace diagnostics as trace metrics - #95

Open
liurenfeng94-ops wants to merge 2 commits into
tsperf:mainfrom
liurenfeng94-ops:trace-diagnostic-source
Open

Label trace diagnostics as trace metrics#95
liurenfeng94-ops wants to merge 2 commits into
tsperf:mainfrom
liurenfeng94-ops:trace-diagnostic-source

Conversation

@liurenfeng94-ops

@liurenfeng94-ops liurenfeng94-ops commented Jul 28, 2026

Copy link
Copy Markdown

This came up because the trace diagnostics looked too similar to the realtime metrics, so I made the trace ones say Trace check ms and marked the diagnostics source/code explicitly in VS Code. I also pulled the message formatting into a small helper and covered it with tests.

Validation:

  • pnpm vitest run test/trace-diagnostic-message.test.ts
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@liurenfeng94-ops

Copy link
Copy Markdown
Author

Thanks for the note — I rewrote the description to be more direct. The change itself is small: it makes the trace diagnostics explicitly read as trace metrics, and it tags the diagnostics so they are clearly separate from the realtime measurements. I can walk through the code path end to end if helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant