Skip to content

Clamp editor trace lookup position - #108

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-goto-trace-position-clamp
Open

Clamp editor trace lookup position#108
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-goto-trace-position-clamp

Conversation

@liurenfeng94-ops

Copy link
Copy Markdown

Fixes an editor-to-trace navigation edge case.

gotoTracePosition subtracts one from the editor offset for normal cursor positions before filtering the trace tree. At the beginning of a file that produced -1, which makes the trace filter behave like no position was supplied. This clamps the computed trace position at zero.

Validation:

  • pnpm vitest run test/editor-trace-position.test.ts
  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant