Skip to content

Allow trace goto at position zero - #104

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-zero-trace-position-goto
Open

Allow trace goto at position zero#104
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-zero-trace-position-goto

Conversation

@liurenfeng94-ops

Copy link
Copy Markdown

Fixes a small trace navigation edge case.

TreeNode showed the goto button whenever a trace line had a position, including pos: 0, but the click handler used a truthy check and returned early for zero. This changes the guard to check only for undefined, so the start of a file remains navigable.

Validation:

  • pnpm vitest run test/trace-position.test.ts
  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@liurenfeng94-ops

Copy link
Copy Markdown
Author

Thanks — I reviewed the text again. The actual fix is just the zero-position guard: pos: 0 should still navigate because the button is shown for defined positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant