Skip to content

Accept corrected delete trace file message - #102

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-delete-trace-file-message
Open

Accept corrected delete trace file message#102
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-delete-trace-file-message

Conversation

@liurenfeng94-ops

Copy link
Copy Markdown

Fixes a small message-name typo without breaking old callers.

The file manager now sends deleteTraceFile, and the shared schema/extension handler accept both the corrected name and the legacy deletTraceFile spelling. That keeps existing messages working while letting new code use the spelled-out name.

Validation:

  • pnpm vitest run test/delete-trace-file-message.test.ts
  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@liurenfeng94-ops

Copy link
Copy Markdown
Author

Thanks — I reviewed the PR text again. The intent is just to move the UI and schema to the correctly spelled deleteTraceFile message while keeping deletTraceFile accepted for compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant