Skip to content

Add fs.access binding - #78

Merged
tschaub merged 1 commit into
tschaub:masterfrom
shyiko:fs_access
Jan 31, 2016
Merged

Add fs.access binding#78
tschaub merged 1 commit into
tschaub:masterfrom
shyiko:fs_access

Conversation

@shyiko

@shyiko shyiko commented Jan 30, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@tschaub tschaub mentioned this pull request Jan 31, 2016
Closed
@tschaub

tschaub commented Jan 31, 2016

Copy link
Copy Markdown
Owner

Thanks for the contribution @shyiko. I'll add some fs.access() tests and cut a new release with this soon.

tschaub added a commit that referenced this pull request Jan 31, 2016
@tschaub
Merge pull request #78 from shyiko/fs_access
e2df8af 
Add fs.access binding.
@tschaub
tschaub merged commit e2df8af into tschaub:master Jan 31, 2016
@shyiko

shyiko commented Jan 31, 2016

Copy link
Copy Markdown
Contributor Author

@tschaub Thank you!

@tschaub tschaub mentioned this pull request Jan 31, 2016
Merged
@tschaub

tschaub commented Jan 31, 2016

Copy link
Copy Markdown
Owner

The docs make it look like fs.access() works on Windows as well. If anybody knows how that works (without process.getuid() and process.getgid()), enhancements to binding.access() are welcome.

@tschaub

tschaub commented Jan 31, 2016

Copy link
Copy Markdown
Owner

Published as mock-fs@3.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shyiko @tschaub