Add support for Node.js v16.3.0+ - #335
Merged
Merged
Conversation
3cp
reviewed
Sep 16, 2021
| let offset; | ||
| let length; | ||
|
|
||
| if (this.signal?.aborted) { |
Collaborator
There was a problem hiding this comment.
Please change the syntax to support old Nodejs v12.
Contributor
Author
There was a problem hiding this comment.
Ah, ofc! 😁, checked that tests are passing locally for me on v12 now too
Rugvip
force-pushed
the
readfilecontext
branch
from
September 16, 2021 08:07
e730c27 to
14e6eaa
Compare
Collaborator
|
Awesome trick! Thank you very much for stretching the life of mock-fs. |
Owner
|
Thanks for the work on this, @Rugvip. Is there a test that could be added that would cover this? I haven't been experiencing the issue myself, so am not 100% clear on the specifics. |
Collaborator
|
@tschaub the existing mock-fs main branch fails test on latest Nodejs v16. |
Contributor
Author
Rugvip
force-pushed
the
readfilecontext
branch
from
September 17, 2021 11:22
c175af6 to
d7237ca
Compare
tschaub
approved these changes
Sep 17, 2021
Owner
|
Thank you for the contribution, @Rugvip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping to fix #332 with this
Large parts of the implementation in
readfilecontext.jsare copied straight from the Node.js internals. I'm assuming that is all fine as it's already called out in the licence file that parts of this project are copied from there.