Conversation
tschaub
marked this pull request as ready for review
April 22, 2021 20:34
Owner
Author
|
Going to consider this very experimental. It shouldn't cause any new issues, but may partially help people who use this library in conjunction with tape. |
AlexanderBelokon
added a commit
to AlexanderBelokon/mock-fs
that referenced
this pull request
Sep 22, 2022
tschaub#322 fixed some issues with `tape`, but introduced a new one: the node process exits with a non-zero code. I believe [this change](https://github.com/tschaub/mock-fs/pull/322/files#diff-f003d52cb508b6a198d1aac361680301de0b3c0a9f800b3d3230da2923029322R271) is responsible for that, and reverting it fixes the issue for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #201.