Conversation
3cp
marked this pull request as draft
March 12, 2021 22:44
assert.fail throws an error. The done() after it will never be reached. It results to a timeout.
3cp
force-pushed
the
opendir
branch
3 times, most recently
from
March 13, 2021 23:08
afb1873 to
85bc620
Compare
3cp
changed the title
3cp
marked this pull request as ready for review
March 14, 2021 02:36
tschaub
approved these changes
Mar 19, 2021
Owner
|
Looks good to me. Thanks, @3cp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was planning to use this branch to implement fs.opendir, but it seems Nodejs would not open up access to internal binding
fs_dirnodejs/node#37746 (comment)This PR fixes mockfs.bypass support of Promise on old Nodejs versions where Promise.prototype.finally is not available. Also cleaned up the tests.