fix: throw ENOTDIR when trying to open an incorrect path (nested under existing file) - #282
Merged
Merged
Conversation
…r existing file) If you have a file: /mock-dir/two.txt and try to open /mock-dir/two.txt/bogus-path, you would get `item.getItem is not a function` due to `item` instance being a File. This adds a fix to this by checking the instance of resolved `item` and throwing accordingly. This matches node's native behavior in such a case.
niieani
force-pushed
the
fix-nested-access
branch
from
November 19, 2019 11:37
3b60be2 to
9adc82f
Compare
tschaub
approved these changes
Nov 25, 2019
Owner
|
Thanks, @niieani. |
Collaborator
|
@tschaub I think you missed the acknowledgement in change log. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a file:
/mock-dir/two.txtand try to open/mock-dir/two.txt/bogus-path, you would getitem.getItem is not a functionError due toiteminstance being a File, not a Directory.This adds a fix to this by checking the instance of resolved
itemand throwing accordingly.This matches node's native behavior in such a case.