Fixing test failures on node 8 - #209
Merged
Merged
Conversation
AGrzes
changed the title
AGrzes
changed the title
Contributor
Author
|
At the moment 32 tests failed in comparison to initial 48. |
Contributor
Author
|
At the moment 32 tests failed in comparison to initial 48. |
Contributor
Author
|
All test failures resolved. |
AGrzes
changed the title
Owner
|
Thanks for the work on this @AGrzes! |
Owner
I removed the duplication in 85396c2 (by adding a |
Merged
Owner
|
Support for Node 8 published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still work in progress.
I managed to fix first issue - with stat function - but there is still a lot of tests failing.