Fix parent perms issues - #105
Merged
Merged
Conversation
added 2 commits
April 22, 2016 16:53
Owner
|
Thanks for the contribution @as3richa. Would you be able to update the tests so they pass on Windows as well? Currently, this just means conditionally running them if |
Author
|
@tschaub Done |
Owner
|
Thanks for the work on this @as3richa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several cases WRT the permissions of parent directories where
mock-fsdoesn't accurately mirror a real filesystem's behaviour. This PR highlights and fixes a few of them, inmkdirandrmdirand their synchronous counterparts. I believe this was reported in #86 (but I didn't read that code in great detail).I think there are more bugs along similar lines with other functions, but these came to my attention immediately because I encountered them in one of my own projects.
The first commit adds five new tests, four of which fail. The second commit fixes these tests.