feat: add TryFrom<i32> implementation to Enumeration - #853
Merged
Conversation
|
Bump, would it be possible to get this reviewed / landed? |
LucioFranco
approved these changes
Aug 25, 2023
LucioFranco
left a comment
LucioFranco
left a comment
Member
There was a problem hiding this comment.
LGTM! Sorry for the delay, thanks for the contribution.
This was referenced Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #812.
This allows us to more easily have generic functions that deal with conversions between i32 and prost Enums.
I took the liberty of deprecating
from_i32and updating the README.md to show how to use the TryFrom instead offrom_i32. I also changed code that usedfrom_i32so that it usestry_from. If this is not how things are usually done in this repo, please tell me so I can undo those changes and make it so the only change is the addition of the TryFrom implementation and the new test.Also, one point that I am not sure about is the Error type of the TryFrom implementation. I used DecodeError, but if that is not suitable and I should create a new Error struct/enum, please tell me so I can fix it.