feat(prost-build): support host specific PROTOC environment variable - #1456
Open
ChrisJr404 wants to merge 1 commit into
Open
feat(prost-build): support host specific PROTOC environment variable#1456ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1083.
When you build on more than one host you currently have to symlink the right
protocinto a fixed path so that a singlePROTOCin.cargo/config.tomlworks everywhere. This adds an optional<HOST>_PROTOCvariable that takes precedence overPROTOC, where the prefix is the host target triple uppercased with-and.turned into_(soX86_64_UNKNOWN_LINUX_GNU_PROTOCon an x86_64 linux host). That matches the namingopenssl-sysuses, and theHOSTvalue comes straight from the variable Cargo sets for build scripts.If the host specific variable is not set, or
HOSTis not present, nothing changes: it falls back toPROTOCand then to looking upprotocon thePATH.I documented it in the "Sourcing protoc" section and added a small test for the variable name derivation.