Skip to content

test: Add DecodeError stack test cases - #1427

Open
oab24413gmai wants to merge 1 commit into
tokio-rs:masterfrom
oab24413gmai:maint/20260521232509
Open

test: Add DecodeError stack test cases#1427
oab24413gmai wants to merge 1 commit into
tokio-rs:masterfrom
oab24413gmai:maint/20260521232509

Conversation

@oab24413gmai

Copy link
Copy Markdown

Summary:

  • Add unit tests for DecodeError construction and Display formatting: cover the nested-message path stack (push/truncate behavior via decode_context-style usage) and verify that error messages render the field path correctly for both empty and deeply-nested cases, plus a From for std::io::Error round-trip assertion. Pure additive tests in the existing #[cfg(test)] module, no behavior change.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@caspermeijn caspermeijn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@caspermeijn caspermeijn changed the title chore: improve prost maintenance path test: Add DecodeError stack test cases May 27, 2026
@caspermeijn

Copy link
Copy Markdown
Member

I fixed main. Could you rebase the PR?

@caspermeijn

Copy link
Copy Markdown
Member

@oab24413gmai Please rebase the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants