Remove query parameters from repo name parsed from binary Cartfile entry - #222
Merged
Conversation
Generated by 🚫 Danger |
tmspzz
reviewed
Apr 19, 2020
tmspzz
left a comment
Owner
There was a problem hiding this comment.
Would be nice to extract this and add a test
hlintBot
reviewed
Apr 29, 2020
| @@ -148,6 +149,17 @@ prop_filterRomeFileEntriesByPlatforms_min :: [RomefileEntry] -> [RomefileEntry] | |||
| prop_filterRomeFileEntriesByPlatforms_min base filteringValues = | |||
| (length $ base `filterRomeFileEntriesByPlatforms` filteringValues) <= length base | |||
There was a problem hiding this comment.
Found Move brackets to avoid $
Why Not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case a Binary entry in the Cartfile has a query parameter, Rome will consider this query parameters as part of the repo name used in the cache, which results in this binary entry not being able to be cached, because the version file doesn't have query parameters in the filename.
To resolve this issue I changed the
gitRepoNameFromCartfileEntrymethod to not only replace the.jsonfile extension, but to split on it and use the head.Reproduction Steps:
carthage bootstrapusing the Cartfile.resolved from belowrome uploadrome downloadExpected behavior:
All dependencies are being fetched from the cache.
Observed behavior:
Rome cannot find the version file, because it looks for the wrong file name.
Problematic Romefile
Note: Using
tealium-carthage-plcrashreporter?_cb=2in the Romefile will result in the framework and dSYM being uploaded and downloaded, but the version file will not be uploaded or downloaded. Usingtealium-carthage-plcrashreporterin the Romefile won't work, because then executingrome list --missingwill outputtealium-carthage-plcrashreporter?_cb=2 1.4.0Problematic Cartfile.resolved
Rome version: 0.23.2.63 - Romam uno die non fuisse conditam.
OS and version: macOS 10.15.4 (19E266)
Additional information: