Skip to content

Add --no-ignore flag - #108

Merged
tmspzz merged 2 commits into
masterfrom
feature/no-ignore
Jan 5, 2018
Merged

Add --no-ignore flag#108
tmspzz merged 2 commits into
masterfrom
feature/no-ignore

Conversation

@tmspzz

@tmspzz tmspzz commented Dec 19, 2017

Copy link
Copy Markdown
Owner

Add --no-ignore flag to all commands with the purpose of ignoring the contents of the [IgnoreMap] section in a Romefile

--no-ignore will instruct Rome to disregards the content of the
[IgnoreMap] section of the current Romefile
@hlintBot

hlintBot commented Dec 19, 2017

Copy link
Copy Markdown
5 Warnings
⚠️ src/Lib.hs#L603 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:1106:5
⚠️ src/Lib.hs#L603 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:1316:5
⚠️ src/Lib.hs#L603 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:1349:5
⚠️ src/Lib.hs#L603 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:1485:5
⚠️ src/Lib.hs#L603 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension <> ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9bcSybolMapPath d = platformBuildDirectory </> bcsymbolmapNameFrom d
10

Why Not

1Combine with src/Lib.hs:664:5

Generated by 🚫 Danger

@tmspzz
tmspzz merged commit 6889453 into master Jan 5, 2018
@tmspzz
tmspzz deleted the feature/no-ignore branch January 5, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants